✨ Support firmware update from HA #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a nice suggestion from @IgorYbema, thanks! Fix #248
kamaradclimber
force-pushed
the
fix248
branch
from
4b9b416 to
4e565ed
Compare
This will allow to detect automatically the board type and thus the binaries to fetch Reference: IgorYbema/HeishaMon#140
For heishamon versions < 3.9, we don't have the `board` field in stats message. Instead we can guess based on the value of `voltage` field which is automatically set to "3.3" for other versions.
|
one suggestion, to determine ESP8266 vs ESP32 before 3.9 you can look at 'stats' and then 'free heap size'. For the esp8266 this can never go beyond 64k and for the ESP32 this is always more free than this 64k limit (or else the ESP32 is leaking memory but you can ignore this situation). Also the static 3.3v is an indication for ESP32 |
|
Good idea, I've added this heuristic in 1.14.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nice suggestion from @IgorYbema, thanks!
Fix #248