Correcting four setting ranges #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix setting ranges for these: SetHeaterStopDelta SetHeaterStartDelta Heater_Delay_Time Heat Outside Low, in J-series can set to -20
|
Hello, thanks for your contribution. Could you show me the source for those values? I'm not sure to find them in heishamon source code (for SetHeaterStopDelta, SetHeaterStartDelta and Heater_Delay_Time). |
|
Panasonic J-series monoblock service manual page 32 and 33
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix setting ranges for these:
SetHeaterStopDelta
SetHeaterStartDelta
Heater_Delay_Time
Heat Outside Low, in J-series can set to -20