Improve support for COP computation #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now recompute COP from mqtt message instead of doing a dance with dynamic templates. It allows to support multiple heatpumps easily and support users who would change entity_ids. Fix #90
|
Is this a breaking change? Former COP value changes to "unknown" after update from 1.2.0 to 1.2.2 and stay like that. |
|
It is in unknown state when there is no power production/consumption. Previous sensor would return a cop of 0. |
|
In terms of data recording (influxdb) I preferred the 0.0 at idle |
|
Also, the naming prefix for all other values is Aquarea. Aquarea COP instead of just COP would be more consistent, right? |
kamaradclimber
added a commit
that referenced
this pull request
Oct 9, 2023
kamaradclimber
added a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now recompute COP from mqtt message instead of doing a dance with dynamic templates.
It allows to support multiple heatpumps easily and support users who would change entity_ids.
Fix #90