Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/attachment headers #43

Closed
wants to merge 5 commits into from
Closed

Feature/attachment headers #43

wants to merge 5 commits into from

Commits on Nov 18, 2021

  1. Respect new arbitrary headers field for attachments 

    This change in contingent upon an update to the bamboo library to
include a `:headers` key in `Bamboo.Attachment` that holds a keyword
list of headers that will override *all* others.

For e.g., in the specific use-case of adding inlined attachments, some
special case headers are required. Now it's possible to add
`X-Attachment-Id` and override the Content-Disposition header with
`inline` to permit the proper display of inlined content, without an
email client showing them as explicit attachments for the user to
download.
    @jarrodmoldrich
    jarrodmoldrich committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    d6eae17 View commit details
    Browse the repository at this point in the history

  2. Temporarily use explicit mail dependency

    @jarrodmoldrich
    jarrodmoldrich committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    895c653 View commit details
    Browse the repository at this point in the history

  3. Upgrade renderer to handle inline attachments... 

    ... and fix tests
    @jarrodmoldrich
    jarrodmoldrich committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    0a1ee5c View commit details
    Browse the repository at this point in the history

  4. Duplicate functions still in elixir-mail PR

    @jarrodmoldrich
    jarrodmoldrich committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    f4c0007 View commit details
    Browse the repository at this point in the history

  5. Revert "Temporarily use explicit mail dependency" 

    This reverts commit 0e2a74c.
    @jarrodmoldrich
    jarrodmoldrich committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    d575a0e View commit details
    Browse the repository at this point in the history