Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-13713): playlist is not updating the active item visually #55

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Feb 28, 2024

  • bugfix

the issue:
when loading a playlist where the player is in autoplay=false and switching between the items, the current active item is not being updated visually (marked with the blue line on the side).

root cause:
setActiveItem happens after MEDIA_LOADED event.
MEDIA_LOADED event is fired only after clicking play; so if choosing an item from the playlist panel and the player is still not starting to play, the active item indication (blue mark) is not being updated.

solution:
listen to CHANGE_SOURCE_ENDED event instead of MEDIA_LOADED.

Solves FEC-13713

@lianbenjamin lianbenjamin merged commit 89f32ee into master Mar 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants