Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9080): when seeking back from end screen no play button displayed #8

Merged
merged 2 commits into from
May 7, 2019
Merged

fix(FEC-9080): when seeking back from end screen no play button displayed #8

merged 2 commits into from
May 7, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 7, 2019 •
edited
Loading

Description of the Changes

Firing SEEKED while ad break, as this event exits the player from ended state (see here)
(No risk because the scrubber is hidden in ad UI)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team May 7, 2019 11:32
@yairans yairans self-assigned this May 7, 2019
@yairans yairans merged commit 6f4bccc into master May 7, 2019
@yairans yairans deleted the FEC-9080 branch May 7, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe