Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10290): upgrade NPM packages #40

Merged
merged 3 commits into from
Jul 26, 2020
Merged

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jul 22, 2020

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from a team July 22, 2020 18:58
webpack.config.js Outdated Show resolved Hide resolved
@@ -29,12 +24,6 @@ module.exports = {
devtool: 'source-map',
plugins: plugins,
module: {
loaders: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-ziv is this not needed anymore?

@dan-ziv dan-ziv merged commit 261fc5e into master Jul 26, 2020
@dan-ziv dan-ziv deleted the upgrade-npm-packages branch July 26, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants