Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ad system is missing in the ad event payload #11

Merged
merged 1 commit into from
May 16, 2019
Merged

fix: ad system is missing in the ad event payload #11

merged 1 commit into from
May 16, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 16, 2019 •
edited
Loading

Description of the Changes

add system to the ad event payload
Depends on kaltura/playkit-js#362

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team May 16, 2019 07:54
@yairans yairans self-assigned this May 16, 2019
@yairans yairans merged commit 05cdfb0 into master May 16, 2019
@yairans yairans deleted the ad-system branch May 16, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe