Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8044): ima-dai plugin #83

Merged
merged 4 commits into from
Apr 15, 2019
Merged

feat(FEC-8044): ima-dai plugin #83

merged 4 commits into from
Apr 15, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Mar 11, 2019 •
edited
Loading

Description of the Changes

Fire hlsFragParsingMetadata events for live tracking

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Mar 11, 2019
@yairans yairans requested a review from a team March 11, 2019 13:12
OrenMe
OrenMe suggested changes Apr 10, 2019
View reviewed changes
src/hls-adapter.js Outdated
@@ -259,6 +260,10 @@ export default class HlsAdapter extends BaseMediaSourceAdapter {
this._trigger(EventType.FPS_DROP, data);
}

_onFragParsingMetadata(data: Object): void {
this._trigger(EventType.TIMED_METADATA, data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename

@yairans yairans changed the title metadata events feat(FEC-8044): ima-dai plugin Apr 11, 2019
@yairans yairans mentioned this pull request Apr 14, 2019
Merged
5 tasks
@yairans yairans merged commit 5658495 into master Apr 15, 2019
@yairans yairans deleted the metadata-events branch April 15, 2019 12:56
yairans added a commit to kaltura/playkit-js-ima-dai that referenced this pull request Apr 15, 2019
@yairans
feat(FEC-8044): ima-dai plugin (#4)
ad005dc 
Depends on:
* kaltura/playkit-js#324 
* kaltura/playkit-js-ui#371 
* kaltura/playkit-js-hls#83
dan-ziv pushed a commit that referenced this pull request Jul 16, 2020
@Yuvalke
fix: logs for DRM checks (#83)
985943c 
fix logger to be in the right place for DRM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe requested changes

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe