fix(FEC-13650): Player v7 | CTA | CTA doesn't show when seeking backwards for the second CTA. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SivanA-Kaltura
requested review from
MosheMaorKaltura,
semarche-kaltura,
JonathanTGold and
lianbenjamin
SivanA-Kaltura
changed the title
semarche-kaltura
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Because activeMessage variable was not cleared correctly, when having two messages, one with timeFromEnd, it was possible to get to a situation where a message wasn't shown twice after seek even though it should be, because of the condition in time update event handler
The fix is to clear activeMessage when hiding a message, and wait for video duration to be set before sorting messages (otherwise timeFromEnd messages would be incorrectly sorted)
Also added fixes for messages not being hidden when showing a new message, and sometimes showing with an incorrect text
Resolves FEC-13650, FEC-13660
CheckLists