Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-13599): Player v7 | CTA | Wrong parameters applied from studio to timeFrom. #10

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix(FEC-13599): Player v7 | CTA | Wrong parameters applied from studio to timeFrom. #10

merged 1 commit into from
Jan 9, 2024

Conversation

SivanA-Kaltura
Copy link
Collaborator

Description of the Changes

Handle negative values in timeFromStart and timeFromEnd fields

Resolves FEC-13599

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura merged commit c29e8b8 into master Jan 9, 2024
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-13599 branch January 9, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lianbenjamin lianbenjamin lianbenjamin approved these changes

@semarche-kaltura semarche-kaltura Awaiting requested review from semarche-kaltura

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SivanA-Kaltura @lianbenjamin