FEM-2417: OTT bookmarks - prevent stop twice on destroy #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the event dispatching order, destroy is handled by the plugin before stop. Then, in the next time stop is sent it contains an incorrect position. The workaround is that if destroy has sent the stop event, stop will not send it again. This behavior needs to be revisited if/when there's a change in event dispatching order.
giladna
approved these changes
Apr 15, 2019
noamtamim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the event dispatching order, destroy is handled by the plugin before stop. Then, in the next time stop is sent it contains an incorrect position.
The workaround is that if destroy has sent the stop event, stop will not send it again.
This behavior needs to be revisited if/when there's a change in event dispatching order.