LIV-1191: fix RTMP timestamp restart #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in time, xx > 0 forward. - extend metadata with pts. a decoded frame pts is reset with its original value. this is because decoder would not respect pts jump baclwards - set async=0 for audio resampler filter. this is to prevent it from adding/removing samples due to pts jump.
igorshevach
requested review from
david-winder-kaltura,
kalturaguy and
shamamayair
kalturaguy
reviewed
Sep 19, 2023
…e and original (ingest) pts which is rolling through the pipeline along with packet/frame.
david-winder-kaltura
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffmpeg decoder produce wrong timestamps when there is a jump backwards.
except for being out of sync with ingest , in the case of audio resampler async set to non zero value it will chop off all incoming streram by said amount thus causing missing audio pieces for the duration of the jump.