fix(SUP-44085): Two different players on the same page #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tzipi-kaltura
requested review from
SivanA-Kaltura,
MosheMaorKaltura and
lianbenjamin
SivanA-Kaltura
requested changes
Sep 2, 2024
5 tasks
SivanA-Kaltura
requested changes
Sep 2, 2024
SivanA-Kaltura
approved these changes
Sep 3, 2024
Tzipi-kaltura
added a commit
to kaltura/playkit-js-audio-player
that referenced
this pull request
Sep 4, 2024
Description of the Changes add the audio preset into audioPlayer object, part of - kaltura/kaltura-player-js#842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
when there 2 or more different players on one page, video player is not loaded fine
Fix:
add the audio preset on new global variable according to the player targetId
pr related - https://github.com/kaltura/playkit-js-audio-player/pull/32/files
Resolves SUP-44085