Exclude variable symbols (felixfbecker#16)

kaloyan-raev · Sep 9, 2016 · 4d5052b · 4d5052b
1 parent 2d4ca8f
commit 4d5052b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 20 deletions.
diff --git a/src/SymbolFinder.php b/src/SymbolFinder.php
@@ -23,7 +23,7 @@ class SymbolFinder extends NodeVisitorAbstract
     /**
      * @var LanguageServer\Protocol\SymbolInformation[]
      */
-    public $symbols;
+    public $symbols = [];
 
     /**
      * @var string
@@ -46,8 +46,24 @@ public function enterNode(Node $node)
         if (!isset(self::NODE_SYMBOL_KIND_MAP[$class])) {
             return;
         }
+
+        $symbol = end($this->symbols);
+        $kind = self::NODE_SYMBOL_KIND_MAP[$class];
+
+        // exclude variable symbols that are defined in methods and functions.
+        if ($symbol && $kind === SymbolKind::VARIABLE &&
+            ($symbol->kind === SymbolKind::METHOD || $symbol->kind === SymbolKind::FUNCTION)
+        ) {
+            if (
+                $node->getAttribute('startLine') - 1 > $symbol->location->range->start->line &&
+                $node->getAttribute('endLine') - 1 < $symbol->location->range->end->line
+            ) {
+                return;
+            }
+        }
+
         $symbol = new SymbolInformation();
-        $symbol->kind = self::NODE_SYMBOL_KIND_MAP[$class];
+        $symbol->kind = $kind;
         $symbol->name = (string)$node->name;
         $symbol->location = new Location(
             $this->uri,

diff --git a/tests/Server/TextDocumentTest.php b/tests/Server/TextDocumentTest.php
@@ -96,24 +96,6 @@ public function testDocumentSymbol()
                 ],
                 'containerName' => null
             ],
-            [
-                'name' => 'testVariable',
-                'kind' => SymbolKind::VARIABLE,
-                'location' => [
-                    'uri' => 'whatever',
-                    'range' => [
-                        'start' => [
-                            'line' => 10,
-                            'character' => 8
-                        ],
-                        'end' => [
-                            'line' => 10,
-                            'character' => 20
-                        ]
-                    ]
-                ],
-                'containerName' => null
-            ],
             [
                 'name' => 'TestTrait',
                 'kind' => SymbolKind::CLASS_,