Update plugin infrastructure and dependencies #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently still a draft since remote service authentication is not working yet for some reason. |
|
@claustres Do you have any thoughts why the authentication test is failing? I believe the way it has been set up should work. |
|
@daffl It seems to me it was actually a bug in the tests: we were authenticating a client on one of the service app using the local strategy while it should only be available on the gateway app, service app should only have JWT strategy. I don't know how it was possible to work previously. |
claustres
reviewed
Mar 31, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades all dependencies to the latest version and updates the plugin infrastructure with the upgrade to Feathers 5 to follow.