Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication management #8

Merged
merged 10 commits into from
Mar 12, 2018
Merged

Authentication management #8

merged 10 commits into from
Mar 12, 2018

Conversation

Flofie
Copy link

@Flofie Flofie commented Mar 6, 2018

Summary

This PR enables authentification on the API Gateway for remote services.

Linked Issue: #4

@claustres
Copy link
Member

Thanks very much for your PR ! I will take some time to analyse this and merge.

By the way, would you be interested in writing an article in Medium for https://blog.feathersjs.com/ ? Or provide me with some inputs on your use case so I can write one by myself.

Thanks again

@claustres
Copy link
Member

Your PR allowed me to work a bit on authentication and I actually updated your code before merging. I kept your improvement regarding hooks on remote services if you only want to expose an API gateway with auth. The example with docker works fine for this.

However I also extended tests to include a more general use case where you want to expose all nodes with auth and not only a gateway. In this specific case you protect your services on each node as usual with the authenticate Feathers hook, so that even when called from another node you have to use an authenticated client.

@claustres claustres merged commit 0c1a3bb into kalisio:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants