Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative includes in Jinja extension #79

Closed

Conversation

Yoshi325
Copy link

Also fixes non-pug includes (they were being parsed as pug).

Issue #78

Also fixes non-pug includes (they were being parsed as pug).

Issue kakulukia#78
@kakulukia
Copy link
Owner

Hi @Yoshi325 ,

thanks for the PR! As i have nearly no time reviewing this, could you please also add a test case that can verify your changes?

Thanks already!

@Yoshi325
Copy link
Author

Yoshi325 commented Nov 2, 2023

I'll do my best!

@kakulukia
Copy link
Owner

Thanks!

@Yoshi325
Copy link
Author

Yoshi325 commented Nov 3, 2023

I am running into trouble following the README to run the testsuite. I see poetry artifacts in the project, but the makefile uses pipenv. Which of those tools to should I be trying to make work for me?

@kakulukia
Copy link
Owner

i obviously have to update this!
Please use those commands:

poetry install
make test

I just did a fresh checkout and this worked: 273 passed, 1 warning in 0.98s

@kakulukia
Copy link
Owner

Hey @Yoshi325 ,

did you continue on this PR? Id like to either merge or close it now as a lot of time has passed.

@Yoshi325
Copy link
Author

Unfortunately this got too big for me to handle as it rippled out into the other exts.

@Yoshi325 Yoshi325 closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants