Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beyond20.js #1080

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update beyond20.js #1080

wants to merge 4 commits into from

Conversation

koalana51066
Copy link

Add targets to chat messages

Add targets to chat messages
@koalana51066
Copy link
Author

Oops, I also added some changes to save targets to tokens. I didn't intend to include those changes but I don't have a version of the file with them separated. I "stole" the code from a module called Token Targeting and adjusted it to suit my needs.

fix findToken to use string instead of request object
When roll is clicked, check for 'is-turn' class and update monster name only if it matches.
Removed token targeting feature
@koalana51066
Copy link
Author

The change to encounter.js is probably in the wrong place. The idea is to send the name of the monster from the tracker card on the left. If there are multiple copies of the same monster, they get appended with (A), (B), etc. Since I try to make my tokens in Foundry the same, I thought it would be nice to know which one was making the roll even though their stat blocks are the same. This is just for having an accurate record in case there are questions later.

My code checks to see if the tracker card name (with "is-turn" class) contains the summary card name. If not, the summary card name is sent. I so, the tracker card name is sent.

@koalana51066
Copy link
Author

The change to findToken() was because I thought it would be useful when you don't have an associated request from which to get the name. I wound up never using it. That could be removed.

@kakaroto
Copy link
Owner

Hi @koalana51066,
Sorry for the delay in reviewing this, I just wanted you to know that I've seen it and will get to fully reviewing when I get the time to work on Beyond20.
And thank you for your contribution, it's very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants