test(proto): add unit tests for metadata descriptors #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor_snmd_getlogstream #919 +/- ##
==============================================================
+ Coverage 79.00% 79.11% +0.10%
==============================================================
Files 180 180
Lines 21615 21615
==============================================================
+ Hits 17078 17100 +22
+ Misses 3720 3695 -25
- Partials 817 820 +3 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
unit_tests_for_metadata_descriptors
branch
from
18fcbc4 to
2f9a7c7
Compare
ijsong
force-pushed
the
refactor_snmd_getlogstream
branch
from
a0af1e1 to
35530c6
Compare
ijsong
force-pushed
the
unit_tests_for_metadata_descriptors
branch
from
2f9a7c7 to
4c8ea0a
Compare
ijsong
force-pushed
the
refactor_snmd_getlogstream
branch
from
35530c6 to
a84aa13
Compare
ijsong
force-pushed
the
unit_tests_for_metadata_descriptors
branch
from
4c8ea0a to
b189424
Compare
- Add tests for StorageNodeMetadataDescriptor and LogStreamReplicaMetadataDescriptor - Test methods: ToStorageNodeDescriptor, GetLogStream, Head, and Tail - Ensure proper coverage for edge cases and nil values
ijsong
force-pushed
the
refactor_snmd_getlogstream
branch
from
a84aa13 to
703a233
Compare
ijsong
force-pushed
the
unit_tests_for_metadata_descriptors
branch
from
b189424 to
f86dca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does