refactor(admin): set dirty field only when the MR is mutated #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
ijsong
force-pushed
the
admin_faster_cmview
branch
from
29c7d20 to
4d1e13e
Compare
ijsong
force-pushed
the
admin_mrmanager_fix_dirty
branch
from
54d0229 to
24aa412
Compare
ijsong
force-pushed
the
admin_faster_cmview
branch
from
4d1e13e to
417a3e8
Compare
ijsong
force-pushed
the
admin_mrmanager_fix_dirty
branch
from
24aa412 to
37fd27f
Compare
hungryjang
approved these changes
Jul 26, 2023
This PR makes the mrmanager avoid unnecessary fetching cluster metadata by checking the dirty field only when the MR is mutated successfully.
ijsong
force-pushed
the
admin_faster_cmview
branch
from
417a3e8 to
3e46f62
Compare
ijsong
force-pushed
the
admin_mrmanager_fix_dirty
branch
from
37fd27f to
083739b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR makes the mrmanager avoid unnecessary fetching cluster metadata by checking the dirty field only when the MR is mutated successfully.