[Feat] #20 인플루언서 좋아요와 반영하여 반환하도록 했어요 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanghee0820
requested changes
Oct 17, 2024
| List<FavoriteInfluencer> findByUserId(Long userId); | ||
|
|
||
| Optional<FavoriteInfluencer> findByUserAndInfluencer(User user, Influencer influencer); |
Comment on lines
44
to
48
| Set<Long> likedInfluencerIds = favoriteRepository.findByUserId(userId).stream() | ||
| .filter(FavoriteInfluencer::isLiked) | ||
| .map(FavoriteInfluencer::getInfluencer) | ||
| .map(Influencer::getId) | ||
| .collect(Collectors.toSet()); |
| FavoriteInfluencer favorite = favoriteRepository.findByUserAndInfluencer(user, influencer) | ||
| .orElseGet(() -> new FavoriteInfluencer(user, influencer)); // 존재하지 않으면 새로 생성 | ||
|
|
||
| favorite.updateLike(param.likes()); | ||
| favoriteRepository.save(favorite); |
There was a problem hiding this comment.
Transaction이 있는데 save가 필요할까요?
There was a problem hiding this comment.
.orElseGet(() -> new FavoriteInfluencer(user, influencer)) 여기서 새 객체 생성되는 경우에는 save 필요하지 않나요?!?
dong-yxxn
approved these changes
Oct 17, 2024
sanghee0820
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
✨ 참고 사항
⏰ 현재 버그
✏ Git Close