Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] #49 Integration 과정에서 발생하는 문제들을 해결해보아요 #53

Merged
merged 6 commits into from
Oct 11, 2024
Merged

[Refactor] #49 Integration 과정에서 발생하는 문제들을 해결해보아요 #53

merged 6 commits into from
Oct 11, 2024

Conversation

BaeJunH0
Copy link
Contributor

✨ 작업 내용

  • Video Url Response 값의 형식을 변경해주는 DTO 로직을 추가했어요
  • Video의 Place 필드가 Null 일 수 있는 상황을 추가했어요
  • Error code의 엔티티에 대한 조회 실패 코드를 NOT_FOUND로 통일하고 Place Error Code도 작성했어요
  • VideoSearchParam -> Place 위치 기반 조회 매개 변수로 바꿔주는 팩토리 메서드를 작성했어요
  • Facade 패턴을 도입하여 service 간의 참조를 없앴어요

✨ 참고 사항

  • x

⏰ 현재 버그

  • x

✏ Git Close

@BaeJunH0 BaeJunH0 added the 🔨 Refactor 코드 리팩토링 label Oct 11, 2024
@BaeJunH0 BaeJunH0 self-assigned this Oct 11, 2024
@BaeJunH0 BaeJunH0 changed the base branch from Master to weekly/6 October 11, 2024 10:27
dong-yxxn
dong-yxxn approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@dong-yxxn dong-yxxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨어요 approve 하겠습니다.

suhyeon7497
suhyeon7497 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@suhyeon7497 suhyeon7497 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve.

@sanghee0820 sanghee0820 merged commit 390399c into weekly/6 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhyeon7497 suhyeon7497 suhyeon7497 approved these changes

@dong-yxxn dong-yxxn dong-yxxn approved these changes

Assignees

@BaeJunH0 BaeJunH0

Labels
🔨 Refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BaeJunH0 @dong-yxxn @suhyeon7497 @sanghee0820