[Feat] #44 TokenRefresh하기~ #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis에 refreshToken이 있으면 재발급합니다. refreshToken이 없을 경우, 잘못된 토큰 에러메세지를 반환합니다. 관련 이슈: #44
…tep3/Team7_BE into feat/#2-authorization
BaeJunH0
approved these changes
Oct 9, 2024
BaeJunH0
approved these changes
Oct 10, 2024
| @AllArgsConstructor | ||
| @Getter | ||
| public enum UserErroCode implements ErrorCode { | ||
| NOT_FOUND(HttpStatus.NOT_FOUND, "U001", "User is not found"); |
Comment on lines
20
to
22
| return !refreshTokenRepository.findById(username).orElseThrow(() -> | ||
| InplaceException.of(AuthorizationErrorCode.INVALID_TOKEN)) | ||
| .getRefreshToken().equals(refreshToken); |
There was a problem hiding this comment.
살짝 읽기 불편한데 orElseThrow 앞에서 줄 바꾸면 안될까요? 아니면 람다식 부분에서
() -> "..." 부분을 한 줄에 하면 좋을 것 같습니다
|
|
||
| @Getter | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @AllArgsConstructor |
| @Repository | ||
| public interface RefreshTokenRepository extends CrudRepository<RefreshToken, String> { | ||
|
|
||
| Optional<RefreshToken> findById(String id); |
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| public class RefreshTokenController { |
| jwtUtil.getUsername(refreshToken), refreshToken); | ||
| addTokenToCookie(response, reIssuedToken); | ||
|
|
||
| return ResponseEntity.ok().build(); |
There was a problem hiding this comment.
저희 new ResponseEntity() 형식으로 하기로 한 거 아니었나요?
Comment on lines
39
to
56
| private void addTokenToCookie(HttpServletResponse response, ReIssued reIssuedToken) { | ||
| Cookie accessTokenCookie = createCookie("access_token", reIssuedToken.accessToken()); | ||
| Cookie refreshTokenCookie = createCookie("refresh_token", reIssuedToken.refreshToken()); | ||
| response.addCookie(accessTokenCookie); | ||
| response.addCookie(refreshTokenCookie); | ||
| } | ||
|
|
||
| private boolean cannotRefreshToken(Cookie cookie) { | ||
| return AuthorizationUtil.getUserId() == null || !jwtUtil.isRefreshToken(cookie.getValue()); | ||
| } | ||
|
|
||
| private Cookie createCookie(String key, String value) { | ||
| Cookie cookie = new Cookie(key, value); | ||
| cookie.setMaxAge(60 * 60); | ||
| cookie.setPath("/"); | ||
| cookie.setHttpOnly(true); | ||
| return cookie; | ||
| } |
There was a problem hiding this comment.
Util 클래스를 만들어야 할까요... Controller에서 처리할 일은 아닌가 싶기도 하구요
관련 이슈: #44
sanghee0820
requested changes
Oct 11, 2024
Comment on lines
16
to
28
| @Override | ||
| public HttpStatus httpStatus() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public String code() { | ||
| return ""; | ||
| } | ||
|
|
||
| @Override | ||
| public String message() { | ||
| return ""; |
There was a problem hiding this comment.
@Getter 로 사용하지 말고 인터페이스에 있는 값 사용 부탁드립니다!
getmethod 빼먹은 부분 을 추가 하였습니다. 관련 이슈 : #44
sanghee0820
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
✨ 참고 사항
⏰ 현재 버그
✏ Git Close