Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #8 CI/CD 관련 수정했어요 #31

Merged
merged 12 commits into from
Oct 4, 2024

Conversation

wndlthsk
Copy link
Contributor

@wndlthsk wndlthsk commented Oct 4, 2024

✨ 작업 내용

  • 도커파일 추가
  • gradle.yml 수정 (조건 수정, 환경변수 파일 생성 추가 및 적용, 테스트 실행 주석으로 추가, 오류 수정)
  • ci/cd 테스트용 컨트롤러 추가

✨ 참고 사항

  • TestController는 나중에 삭제해도 됩니다! 변경사항 있을 때 배포 잘 되는지 확인하려고 만들었습니다.
  • 인스턴스는 제 계정으로 만들어서 테스트해봤습니다. 배포 시작할 때 새로 만들겠습니다
  • 시크릿 설정과 self-hosted 설정도 배포 전 필요합니다

⏰ 현재 버그


✏ Git Close

@wndlthsk wndlthsk added the ✨ Feature 기능 개발 label Oct 4, 2024
@wndlthsk wndlthsk self-assigned this Oct 4, 2024
Copy link
Contributor

@sanghee0820 sanghee0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BaeJunH0 BaeJunH0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI/CD 부분 처음이라 어려우셨을 것 같은데 잘 하신 것 같습니다!

@sanghee0820 sanghee0820 merged commit c71e1aa into kakao-tech-campus-2nd-step3:weekly/5 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants