Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: RecruitDetail 수정 #125

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

tteokbokki-master
Copy link
Contributor

RecruitDetail 수정

useGetRequiredFieldCheck(필수값 체크) recruitmentId 제거

export const useGetRequiredFieldCheck = () =>
  useQuery<RequiredFieldCheckProps, Error>({
    queryKey: ['RequiredFieldCheckProps'],
    queryFn: () => getRequiredFieldCheck(),
  });

필수 값을 구인글 페이지마다 구분할 필요가 없음을 알게 되어, 매개변수로 받던 recruitmentId를 제거했습니다.

백엔드 응답 형식 반영

majorBusiness: string;
eligibilityCriteria: string;
preferredConditions: string;

백엔드 응답 형식에 맞게 타입을 문자열로 변경하고, 스토리북 및 컴포넌트도 수정했습니다.

백엔드 응답 값 조건부 렌더링

<SectionWithTitle title={t('recruit.detailedDescription')}>
    {language && language === 'ko' ? koreanDetailedDescription : vietnameseDetailedDescription}
</SectionWithTitle>

현재 선택된 언어에 따라 다른 값이 렌더링 됩니다.

- 패스 파라미터를 추가했습니다.
- useGetRequiredFieldCheck(필수값 체크) recruitmentId 제거
- RecruitDetailProps 타입 수정
- RecruitDetail 스토리북 수정
- RecruitDetail map 메서드 삭제
@tteokbokki-master tteokbokki-master self-assigned this Nov 11, 2024
@YIMSEBIN YIMSEBIN merged commit 9cb30b9 into kakao-tech-campus-2nd-step3:Weekly Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants