feat: 응답헤더로 cookie set (httponly, secure 적용) #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbm0524
approved these changes
Nov 3, 2024
ajy9851
approved these changes
Nov 3, 2024
nove1080
approved these changes
Nov 4, 2024
|
|
||
| return ResponseEntity.ok() | ||
| .headers(headers) | ||
| .body(ApiResponse.with(HttpStatus.OK, "로그인 성공", serviceToken)); | ||
| } else { |
There was a problem hiding this comment.
움 그냥 넣을래요! 그게 분리되어 보여서 좋아요~
| @@ -63,6 +78,20 @@ public ResponseEntity<ApiResponse<String>> signUpMember( | |||
| String serviceToken = | |||
There was a problem hiding this comment.
@PostMapping("/signup")
public ResponseEntity<ApiResponse<String>> signUpMember(@RequestParam String email, @RequestBody MemberInfoRequest memberInfoRequest)여기서 email 정보만 RequestParam 으로 선언한 이유가 궁금해요
There was a problem hiding this comment.
리다이렉트 페이지 url이랑 같이 보내는 거라서 param에 있는게 좋을 것 같아서요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 내용
응답헤더로 cookie set했습니다. httponly, secure 옵션 적용
기존 서버(http) - 프론트(로컬)로 통신하였는데 https로 통신할 예정입니다.
