Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

충남대 FE_박건민 1주차 과제 #96

Open
wants to merge 16 commits into
base: geonbur
Choose a base branch
from

Conversation

geonbur
Copy link

@geonbur geonbur commented Jul 3, 2024

재제출입니다.

@geonbur geonbur changed the title 충남대 FE_박건민 1주차 과제 제출 충남대 FE_박건민 1주차 과제 Jul 3, 2024
Copy link

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재제출하신 PR에 제가 리뷰 제출했다고 생각했는데, 드리지 않았군요. 늦게 나마 드립니다. 지금은 2주차 구현에 집중하고 계실거라 충돌 해결되면 바로 병합해둘게요.

name: '@storybook/react-webpack5',
options: {},
},
staticDirs: ['..\\public'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
staticDirs: ['..\\public'],
staticDirs: ['../public'],

path 인식을 하지 못해서 오류가 발생하고 있네요.

code {
font-family: source-code-pro, Menlo, Monaco, Consolas, 'Courier New',
monospace;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run format을 실행하니 index.css, reset.css가 적용되어 있지 않네요. 실행 후 커밋해서 푸쉬해주시겠어요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants