전남대 Android_장수민_6주차 과제(2단계) #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omjoonkim
approved these changes
Aug 5, 2024
| @@ -0,0 +1,55 @@ | |||
| //package campus.tech.kakao.map | |||
| // | |||
| //class NotificationPermissionManager { | |||
There was a problem hiding this comment.
불필요한 코드(주석)등은 지우는 것이 리뷰어와 리뷰를 받는 입장 모두에게 좋습니다. :)
| fetchRemoteConfig() | ||
| } | ||
| fun fetchRemoteConfig() { | ||
| RemoteConfig.fetchAndActivate { success -> |
There was a problem hiding this comment.
RemoteConfig를 직접사용하지 말고 역할을 위임하는 컴포넌트를 만들어 사용하도록 변경해보세요.
SplashViewModel의 테스트 코드를 어떻게 작성할지에 대해서 생각하다보면 이유를 아실 수 있으실거에요.
|
6주차동안 과제 진행하시느라 고생 많으셨습니다~! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6주차 과제
🛠️기능 사항(1단계)
🛠️기능 사항(2단계)
학습과 오류 해결에 시간이 오래 걸려 부득이하게 1단계와 2단계를 한 번에 작업했습니다... 늦게 제출해서 정말 죄송합니다!!! 😭😭
1단계 작업부분
그동안 코드리뷰 해주셔서 정말 감사했습니다! 도움이 많이 되었습니다!!!
어려운점
의존성 주입과 함께 사용하려고 하다보니 그 과정에서 오류를 많이 만났던 것 같습니다... ㅠㅠ
📷앱 사진(왼쪽-커스텀 알림, 오른쪽-FCM)