Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RIETextArea - fixes #4 #9

Merged
merged 2 commits into from
Aug 23, 2016
Merged

Conversation

devvmh
Copy link
Contributor

@devvmh devvmh commented Aug 3, 2016

I'm really interested in using this library with a textarea component in a project I'm working on, so am open to doing whatever to get this merged.

Textareas are the same as an input, with 3 differences:

  1. Hitting Enter adds a newline, rather than calling stopEditing
  2. The span displaying the results converts newlines into br tags
  3. Textareas accept rows & cols as a property.

@devvmh
Copy link
Contributor Author

devvmh commented Aug 23, 2016

@kaivi thoughts on merging? This has been working for me in production and I'd love to get the git url out of my package.json. Thanks! Whenever you get a chance it would be great!

@kaivi kaivi merged commit 32eb9fa into kaivi:master Aug 23, 2016
@kaivi
Copy link
Owner

kaivi commented Aug 23, 2016

Thank you, I have now merged and uploaded a new version to NPM

@devvmh devvmh deleted the feature/textarea branch August 24, 2016 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants