-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RIESelect component #10
Conversation
I just commited 8f70f07, I think that passing select options as an object is the best way to go. It's more elegant and makes it easier to convert data from a database. I changed |
If we don't want to edit the base class then we could redefine |
Just installed this PR and played around with it some in a site I'm building. It works just fine but I question if it's necessary? With this in-place select component you have to click it twice to edit it whereas with a normal select you need to click just once which seems more in-line with this lib's philosophy. Thoughts? Perhaps just recommend people use a normal |
Thanks for checking out the PR! I'd like to not see a select box when displaying the data but I'd like to see the select box when editing. Clicking twice is inconvenient, but figuring out how to open the select box on the first click would be a great future PR. |
Hey, sorry it took so long, It is merged and published as v 1.0.5 now! |
To open the select immediately you can I believe just pass the click through. |
I needed a select component in a project I'm working on and figured I'd do a solid and add it to this repo, I really like what you've build here.
Let me know if there's anything I could change in this commit. I chose to pass the select options as an object, but it could just as easily be passed as a list of objects like so:
map
instead offor
loopI had to put a conditional in
RIEBase.js
since<select>
elements don't have the functionsetSelectionRange
.