Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot update changed messages in the dictionary #130

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Fix cannot update changed messages in the dictionary #130

merged 3 commits into from
Mar 17, 2021

Conversation

bbuhler
Copy link
Contributor

@bbuhler bbuhler commented Feb 24, 2021

Hello (:

This is a fix for #107. It clears the lookupCache for a locale when addMessages is called.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test

@bbuhler
Copy link
Contributor Author

bbuhler commented Feb 24, 2021

I just found out that you have already a related branch (https://github.com/kaisermann/svelte-i18n/tree/fix/lookup-caching).
Though my solution is a quick'n'dirty, it would unblock me with my current work.
Feel free to close this in favor of your changes.

Never mind, I confused the dates. 🤦🏼
Now I realized that your branch is from 2020 and older than the actual issue.

@bbuhler
Copy link
Contributor Author

bbuhler commented Mar 17, 2021

@kaisermann can you please merge this or give any feedback (:

@kaisermann
Copy link
Owner

Hey @bbuhler 👋 I'm not sure if clearing the whole locale cache is the best way to do this, but I don't have an alternative right now. thanks!

@kaisermann kaisermann merged commit 88ad5b2 into kaisermann:main Mar 17, 2021
@bbuhler bbuhler deleted the fix/issue-107 branch March 18, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants