fix: clear locale lookup cache when new messages are added (#130)

* Added test to prove that addMessage is not updating returned messages * Clear lookupCache for locale when addMessages is called * Update test/runtime/includes/lookup.test.ts Co-authored-by: Christian Kaisermann <[email protected]>
kaisermann · Mar 17, 2021 · 88ad5b2 · 88ad5b2
1 parent d4b9881
commit 88ad5b2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/runtime/stores/dictionary.ts b/src/runtime/stores/dictionary.ts
@@ -4,6 +4,7 @@ import deepmerge from 'deepmerge';
 import type { LocaleDictionary, LocalesDictionary } from '../types/index';
 import { getFallbackOf } from './locale';
 import { delve } from '../../shared/delve';
+import { lookupCache } from '../includes/lookup';
 
 let dictionary: LocalesDictionary;
 const $dictionary = writable<LocalesDictionary>({});
@@ -39,6 +40,8 @@ export function getClosestAvailableLocale(locale: string): string | null {
 }
 
 export function addMessages(locale: string, ...partials: LocaleDictionary[]) {
+  delete lookupCache[locale];
+
   $dictionary.update((d) => {
     d[locale] = deepmerge.all<LocaleDictionary>([d[locale] || {}, ...partials]);
 

diff --git a/test/runtime/includes/lookup.test.ts b/test/runtime/includes/lookup.test.ts
@@ -83,3 +83,11 @@ test("doesn't cache falsy messages", () => {
     pt: { field_2: 'nome' },
   });
 });
+
+test('clears a locale lookup cache when new messages are added', () => {
+  addMessages('en', { field: 'name' });
+  expect(lookup('field', 'en')).toBe('name');
+
+  addMessages('en', { field: 'name2' });
+  expect(lookup('field', 'en')).toBe('name2');
+});