Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golang information to the --version output #452

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

jimmykarily
Copy link
Contributor

so that we can call it to verify we built a fips version by greping for "boringcrypto" in the output.

Part of: kairos-io/kairos#1609

Will be used here: kairos-io/packages#334

so that we can grep for "boringcrypto" in the output as part of this:

kairos-io/packages#334

Signed-off-by: Dimitris Karakasilis <[email protected]>
@jimmykarily jimmykarily force-pushed the 1609-add-version-cmd branch from c0b8e6f to 2839a1e Compare July 18, 2023 09:40
@jimmykarily jimmykarily changed the title Add "version" command to the cli Add golang information to the --version output Jul 18, 2023
@jimmykarily jimmykarily self-assigned this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #452 (f42fc3a) into main (9f56a55) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   12.39%   12.27%   -0.12%     
==========================================
  Files          17       17              
  Lines        1065     1075      +10     
==========================================
  Hits          132      132              
- Misses        906      916      +10     
  Partials       27       27              
Impacted Files Coverage Δ
internal/cli/start.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my request can come later as it requires some more small changes

to be consistent with the rest of our binaries (immucore, kairos-agent etc)

Signed-off-by: Dimitris Karakasilis <[email protected]>
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@jimmykarily jimmykarily merged commit 086c92b into main Jul 19, 2023
@jimmykarily jimmykarily deleted the 1609-add-version-cmd branch July 19, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants