-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iso builder #70
Merged
Merged
Add iso builder #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new package for the iso builder run directly on go. This is extracted from the original elemental-cli and then from the now build-less kairos-agent This uses no deps on elemental, only deps are on kairos-agent for the config stuff mainly. Signed-off-by: Itxaka <[email protected]>
Install all packages via luet, converges the rpi packages into one, makes arm use the same generic packages as x86 as they now come from the proper architecture and reduces dockerfile complexity Signed-off-by: Itxaka <[email protected]>
Itxaka
force-pushed
the
osbuilder_go
branch
2 times, most recently
from
July 18, 2023 13:15
828905c
to
dc79429
Compare
Signed-off-by: Itxaka <[email protected]>
Seems to work, this branch is using a new osbuilder pushed with this branch changes and everything was build correctrly: |
jimmykarily
reviewed
Jul 19, 2023
jimmykarily
reviewed
Jul 19, 2023
jimmykarily
reviewed
Jul 19, 2023
jimmykarily
reviewed
Jul 19, 2023
jimmykarily
reviewed
Jul 19, 2023
jimmykarily
reviewed
Jul 19, 2023
jimmykarily
reviewed
Jul 19, 2023
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Tested again with the latest changes, still working |
mauromorales
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Itxaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new package for the iso builder run directly on go. This is extracted from the original elemental-cli and then from the now build-less kairos-agent
This uses no deps on elemental, only deps are on kairos-agent for the config stuff mainly.
Part of kairos-io/kairos#711
I have already build an iso with this and seems to work. Command should be a drop-in replacement of elemental-cli for building isos.
The main difference is dropping uneeded stuff (like bootloader-in-rootfs), convergin the constants in one place, dropping the liveiso stuff as we dont need that at all and disabling squashfs compression by default
Also updates the dockerfile to be simpler, install everything from the repository directly