Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k3s service is broken on systemd #1797

Closed
jimmykarily opened this issue Sep 7, 2023 · 3 comments · Fixed by #1802
Closed

k3s service is broken on systemd #1797

jimmykarily opened this issue Sep 7, 2023 · 3 comments · Fixed by #1802
Labels
bug Something isn't working prio: high

Comments

@jimmykarily
Copy link
Contributor

jimmykarily commented Sep 7, 2023 •
edited
Loading

systemd has a compatibility feature with sysv (https://www.turnkeylinux.org/blog/debugging-systemd-sysv-init-compat). Since we copy all services, both systemd and openrc, when the service is started, it fails with an error.

We need to remove the openrc bits from systemd systemds
@jimmykarily jimmykarily converted this from a draft issue Sep 7, 2023
@jimmykarily jimmykarily added prio: high bug Something isn't working labels Sep 7, 2023
This was referenced Sep 7, 2023
Closed
Merged
@Itxaka
Copy link
Member

Itxaka commented Sep 7, 2023

How is this not hitting our test suite? We have a check for k3s status no?

@jimmykarily
Copy link
Contributor Author

How is this not hitting our test suite? We have a check for k3s status no?

As it seems, no. We check various things but not that the service is running. We need to do add that check.

jimmykarily pushed a commit to kairos-io/packages that referenced this issue Sep 8, 2023
@mudler
Split k3s package in 2 (one for openrc, one for systemd)
4a25682 
because having all service files in places, confuses systemd because of
the sysv compatibility feature.

Part of: kairos-io/kairos#1797

Signed-off-by: Dimitris Karakasilis <[email protected]>
@jimmykarily jimmykarily mentioned this issue Sep 8, 2023
Merged
@Itxaka
Copy link
Member

Itxaka commented Sep 8, 2023

ah maybe its because on testing we use latest and that installs the k3s service directly! So it only installs the proper service file, while installing from package would install our package with both files.

jimmykarily added a commit to kairos-io/packages that referenced this issue Sep 8, 2023
@jimmykarily @mudler
Split k3s package in 2 (one for openrc, one for systemd) (#412)
038ee95 
* Split k3s package in 2 (one for openrc, one for systemd)

because having all service files in places, confuses systemd because of
the sysv compatibility feature.

Part of: kairos-io/kairos#1797

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Use new names for the new packages

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Use one definition for both packages with templating

Signed-off-by: Dimitris Karakasilis <[email protected]>

---------

Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Co-authored-by: Ettore Di Giacinto <[email protected]>
jimmykarily added a commit that referenced this issue Sep 8, 2023
@jimmykarily
Install the right k3s package based on the init system
d6bfa61 
Fixes: #1797

Signed-off-by: Dimitris Karakasilis <[email protected]>
@jimmykarily jimmykarily mentioned this issue Sep 8, 2023
Merged
jimmykarily added a commit that referenced this issue Sep 8, 2023
@jimmykarily
Install the right k3s package based on the init system (#1802)
536b26d 
* Install the right k3s package based on the init system

Fixes: #1797

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Bump luet repository to use the new packages

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Add FLAVOR ARG for consistency

although it's a global and it should work anyway. But we pass it in
other places so let's at least be consistent.

Signed-off-by: Dimitris Karakasilis <[email protected]>

---------

Signed-off-by: Dimitris Karakasilis <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo 🖊 to Done ✅ in 🧙Issue tracking board Sep 8, 2023
jimmykarily added a commit that referenced this issue Sep 13, 2023
@jimmykarily
Use one of our luet packages to install k3s
3400c7c 
Fixing this: #1797 (comment)

Signed-off-by: Dimitris Karakasilis <[email protected]>
@jimmykarily jimmykarily mentioned this issue Sep 13, 2023
Merged
jimmykarily added a commit that referenced this issue Sep 13, 2023
@jimmykarily
Use one of our luet packages to install k3s (#1814)
ec1706c 
* Use one of our luet packages to install k3s

Fixing this: #1797 (comment)

Signed-off-by: Dimitris Karakasilis <[email protected]>

* [Temp] Run provider tests in PRs temporarily to test this PR

Signed-off-by: Dimitris Karakasilis <[email protected]>

* Revert "[Temp] Run provider tests in PRs temporarily to test this PR"

This reverts commit 41babdf.

---------

Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily pushed a commit to kairos-io/provider-kairos that referenced this issue Dec 12, 2023
@mudler
fix: better error messages (#477)
f71257e 
related to: kairos-io/kairos#1797

Signed-off-by: mudler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working prio: high
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install the right k3s package based on the init system kairos-io/kairos
2 participants
@Itxaka @jimmykarily