This repository has been archived by the owner on Dec 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
feat(gallery, account, album, image): implement delete actions #78
Merged
kaimallea
merged 1 commit into
kaimallea:master
from
cacheflow:implement-delete-actions
Aug 19, 2019
Merged
feat(gallery, account, album, image): implement delete actions #78
kaimallea
merged 1 commit into
kaimallea:master
from
cacheflow:implement-delete-actions
Aug 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacheflow
force-pushed
the
implement-delete-actions
branch
from
August 17, 2019 22:08
545b9e6
to
4c71849
Compare
holy moly 🔥 |
kaimallea
suggested changes
Aug 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks! Just one small bit of feedback
* @returns https://api.imgur.com/account/v1/{{username}}/block | ||
*/ | ||
|
||
const createUnblockUrl = (username: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 🛠
cacheflow
force-pushed
the
implement-delete-actions
branch
from
August 19, 2019 18:35
4c71849
to
5c713fb
Compare
cacheflow
force-pushed
the
implement-delete-actions
branch
from
August 19, 2019 18:42
5c713fb
to
cdac045
Compare
kaimallea
reviewed
Aug 19, 2019
client: Client, | ||
username: string, | ||
): Promise<ImgurApiResponse | AuthenticationRequiredResponse> { | ||
return client.delete(`${createUnblockUrl(username)}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah so delete
just works via the api docs 👍
kaimallea
approved these changes
Aug 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
tyvm!! 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope: client