Skip to content
This repository has been archived by the owner on Dec 30, 2021. It is now read-only.

feat(gallery, account, album, image): implement delete actions #78

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

cacheflow
Copy link
Collaborator

scope: client

@kaimallea
Copy link
Owner

holy moly 🔥

Copy link
Owner

@kaimallea kaimallea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks! Just one small bit of feedback

* @returns https://api.imgur.com/account/v1/{{username}}/block
*/

const createUnblockUrl = (username: string) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🛠

src/account/unblock.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
@cacheflow cacheflow force-pushed the implement-delete-actions branch from 4c71849 to 5c713fb Compare August 19, 2019 18:35
@cacheflow cacheflow force-pushed the implement-delete-actions branch from 5c713fb to cdac045 Compare August 19, 2019 18:42
client: Client,
username: string,
): Promise<ImgurApiResponse | AuthenticationRequiredResponse> {
return client.delete(`${createUnblockUrl(username)}`);
Copy link
Owner

@kaimallea kaimallea Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah so delete just works via the api docs 👍

Copy link
Owner

@kaimallea kaimallea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kaimallea kaimallea merged commit 5322350 into kaimallea:master Aug 19, 2019
@kaimallea
Copy link
Owner

tyvm!! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants