Remove istanbul validator and istanbul snapshot #190
+193
−4,302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoomee1313
force-pushed
the
remove-istanbul-snapshot
branch
from
445b465 to
6bafd67
Compare
blukat29
reviewed
Jan 3, 2025
| if headers, err = s.Engine().GetKaiaHeadersForSnapshotApply(s.blockchain, currBlock.NumberU64(), currBlock.Hash(), nil); err != nil { | ||
| logger.Error("Failed to get headers to apply", "err", err) | ||
| } else { | ||
| preloadRef, err := reward.PreloadStakingInfo(s.blockchain, headers, mStaking) |
There was a problem hiding this comment.
We can delete reward/staking_manager.go:PreloadStakingInfo and related types as well.
| } | ||
| weightedVals[vIdx] = weightedVal | ||
|
|
||
| if cIdx, err := stakingInfo.GetIndexByNodeAddress(weightedVal.address); err == nil { |
There was a problem hiding this comment.
We can delete most methods of the old reward.StakingInfo type.
ian0371
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLAin first time contribute$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...