Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sphinx 7 #1512

Closed
kai687 opened this issue Sep 22, 2023 · 1 comment · Fixed by #1595
Closed

Support Sphinx 7 #1512

kai687 opened this issue Sep 22, 2023 · 1 comment · Fixed by #1595

Comments

@kai687
Copy link
Owner

kai687 commented Sep 22, 2023

The way we add DocSearch to the site won't work with Sphinx versions >7.
See: #1511 (comment)

  • I tried using the builder-inited event, but it seems that app.builder.globalcontext is not yet defined at that stage
This was referenced Sep 22, 2023
Closed
Closed
@kai687
Copy link
Owner Author

kai687 commented Oct 13, 2023

If we want to support Sphinx 5, we need to import sphinx.util.progress_message for Sphinx 5 and 6 and sphinx.util.display.progress_message for Sphinx 7.

See #1538

@kai687 kai687 linked a pull request Nov 30, 2023 that will close this issue
fix: make work with Sphinx 7 #1595
Merged
@kai687 kai687 mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make work with Sphinx 7 kai687/sphinxawesome-theme
1 participant
@kai687