Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme breaks with Sphinx 7.2.0 #1464

Closed
kai687 opened this issue Aug 17, 2023 · 5 comments · Fixed by #1595
Closed

Theme breaks with Sphinx 7.2.0 #1464

kai687 opened this issue Aug 17, 2023 · 5 comments · Fixed by #1595
Assignees
Labels
bug Something isn't working

Comments

@kai687
Copy link
Owner

kai687 commented Aug 17, 2023

Trying to build fails with Sphinx 7.2.0 with the following error:

Theme error:
An error happened in rendering the page index.
Reason: TypeError("argument of type '_CascadingStyleSheet' is not iterable")
@kai687 kai687 self-assigned this Aug 17, 2023
@kai687 kai687 added the bug Something isn't working label Aug 17, 2023
@humitos
Copy link

humitos commented Aug 17, 2023

We are having the same issue with the Read the Docs Sphinx Theme. See readthedocs/sphinx_rtd_theme#1502 cc @picnixz

kai687 added a commit that referenced this issue Aug 17, 2023
Fixes the copy button target to copy only the code, not the tooltip
text.
Pinned the Sphinx version because of #1464.
@kai687
Copy link
Owner Author

kai687 commented Aug 29, 2023

Well, early investigations are a bit of a bummer:

Sphinx 7.2 dropped Python 3.8 support, but it's still a supported Python release, so the theme should continue to work with Python 3.8 (and Sphinx versions < 7).

That means, as a theme author, I need to support both worlds: (paths as strings vs. paths as paths, Sphinx testing utility, CSS file/JS file type changes).

Or I just throw my hands up and drop support for Python 3.8 going forward.

@kai687
Copy link
Owner Author

kai687 commented Sep 22, 2023

Related issue: #1512

@DeepakArora76
Copy link

I'm eager to know when this issue will be resolved. Can you share any insights on the timeline?

@kai687
Copy link
Owner Author

kai687 commented Oct 8, 2023

@DeepakArora76 Unfortunately no. Version 5 of this project is still in beta and I don't know when I'll be able to resolve all remaining issues.

@kai687 kai687 linked a pull request Nov 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants