Enable graceful shutdown of a GenConsumer #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1az
force-pushed
the
graceful_shutdown
branch
2 times, most recently
from
eb1c242
to
64ee1ca
Compare
b1az
force-pushed
the
graceful_shutdown
branch
from
64ee1ca
to
5ecc2c4
Compare
Add a user-configurable :shutdown to GenConsumer's child_spec. Addresses kafkaex#434.
start_link/1 was added in PR kafkaex#473.
b1az
force-pushed
the
graceful_shutdown
branch
from
5ecc2c4
to
6cb273b
Compare
|
@Argonus and @joshuawscott, I've been already using the proposed change, as the worker's (default) If you'll find time, any feedback, either affirmative or dismissive, would be much appreciated. (Especially given that I already went ahead and use this in production.) |
|
@joshuawscott I've tested that on my own setup, it works well with different shutdowns time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a user-configurable
:shutdowntoGenConsumer's child_spec.Addresses #434, if
do_some_job, from the referred issue, is either synchronous or async. Not sure if the change covers the case of a cluster rebalance.