Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka lets us set produce and consume quotas to prevent badly behaved consumers/producers from eating up all the bandwidth of a broker, read more about it here: https://kafka.apache.org/documentation/#design_quotas
Kafka support's enforcing quota's by
client_id
,user_id
, or byuser_id,client_id
pairs, but we don't use ACL's and as such we mainly care for Client ID based quota calculations.KafkaEx currently does not support this use case since it hard codes the client id to
kafka_ex
. All services that interact with kafka will be accounted for under the same Quota.This PR exposes the client id to be configurable by library users: