Allow specifying versions for offset commit and fetch #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuawscott
approved these changes
Sep 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also made a small change in client.ex to allow the node_id node selector to work (and any other that can pass through straight to ClusterMetadata).
Also FWIW I found that if you commit to zookeeper (v0) and try to fetch the same consumer group from kafka (v > 0), you get
:topic_or_partition_not_found. If you commit to kafka (v > 0) and try to fetch from zookeeper, you get an offset of -1. So people who have already been committing to zookeeper will need a migration plan.