Add credo to CI tests #316
Conversation
|
does ebert not provide the same functionality as credo? |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
scripts/ci_tests.sh
Outdated
| mix "$TEST_COMMAND" $INCLUDED_TESTS | ||
| fi | ||
| # Retry if it doesn't work the first time | ||
| mix "$TEST_COMMAND" $INCLUDED_TESTS || mix "$TEST_COMMAND" $INCLUDED_TESTS |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting.
scripts/ci_tests.sh
Outdated
| mix "$TEST_COMMAND" $INCLUDED_TESTS | ||
| fi | ||
| # Retry if it doesn't work the first time | ||
| mix "$TEST_COMMAND" $INCLUDED_TESTS || mix "$TEST_COMMAND" $INCLUDED_TESTS |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting.
|
It does, but this gives the extra layer of ensuring that credo passes, or it will fail the test suite. It's currently passing, which was our roadblock in the past to enabling it, if I recall correctly. |
scripts/ci_tests.sh
Outdated
| @@ -6,8 +6,15 @@ | |||
| # | |||
| # This script could be used for local testing as long as COVERALLS is not set. | |||
|
|
|||
| set -e | |||
There was a problem hiding this comment.
Instead of this, do we want to run both and then have it report which things failed?
There was a problem hiding this comment.
set -ex probably will be more obvious on which failed
| mix "$TEST_COMMAND" $INCLUDED_TESTS | ||
| fi | ||
| # Retry if it doesn't work the first time | ||
| mix "$TEST_COMMAND" $INCLUDED_TESTS || mix "$TEST_COMMAND" $INCLUDED_TESTS |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting.
| mix "$TEST_COMMAND" $INCLUDED_TESTS | ||
| fi | ||
| # Retry if it doesn't work the first time | ||
| mix "$TEST_COMMAND" $INCLUDED_TESTS || mix "$TEST_COMMAND" $INCLUDED_TESTS |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting.
There was a problem hiding this comment.
This is incorrect. Quoting this changes the meaning of the arguments.
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/kafkaex/kafka_ex/pulls/316. |
Fixes #100