Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc tidy ups #302

Merged
merged 5 commits into from
Aug 16, 2018
Merged

Misc tidy ups #302

merged 5 commits into from
Aug 16, 2018

Conversation

IanVaughan
Copy link
Contributor

Changes I made while I was working on another branch, now extracted to their own branch to reduce the changeset in that one.

@sourcelevel-bot
Copy link

Hello, @IanVaughan! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@IanVaughan
Copy link
Contributor Author

Closing to reopen to trigger a test re-run.

@IanVaughan IanVaughan closed this Aug 16, 2018
@IanVaughan IanVaughan reopened this Aug 16, 2018
Copy link
Member

@joshuawscott joshuawscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Thanks for the cleanup!

Copy link
Member

@bjhaid bjhaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joshuawscott joshuawscott merged commit 3a8b99d into kafkaex:master Aug 16, 2018
@IanVaughan IanVaughan deleted the misc-tidy-ups branch August 16, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants