safe_gen_call catches more exit exceptions #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
fix/timeout-brod-client
branch
from
8d57160
to
d8b75a2
Compare
brod_client safe_gen_call implementation leaked timeouts
all safe_gen_call calls have infinity timeout
zmstone
force-pushed
the
fix/timeout-brod-client
branch
from
d8b75a2
to
08fb56c
Compare
zmstone
force-pushed
the
fix/timeout-brod-client
branch
from
08fb56c
to
f867a4a
Compare
Prior to this change the actual time spent in establishing a Kafka connection might be longer than desired due to the timeout being used in SSL upgrade (if enabled), then API version query. This has been fixed by turning the given timeout config into a deadline, and the sub-steps will try to meet the deadline. see more details here: kafka4beam/kafka_protocol#92
zmstone
force-pushed
the
fix/timeout-brod-client
branch
from
f867a4a
to
32d09d6
Compare
v0idpwn
approved these changes
Feb 6, 2022
k32
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
safe_gen_calls catch allexitexceptions (propagated from the callee'sDOWNevent, or timeout).