Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the grants.critical.range flag #67

Merged
merged 9 commits into from
Apr 6, 2024
Merged

Conversation

kaelad02
Copy link
Owner

@kaelad02 kaelad02 commented Apr 5, 2024

Conditions like Paralyzed turn hits into crits if the attacker is adjacent. Helpful since a previous feature added this flag to the system-defined status effects.

There's an issue with Ready Set Roll though. It doesn't really do well with setting the critical flag in general, really just relying on whether the attack roll was a crit. So for now, it's effectively disabled by setting the distance to Infinity so the flag will be ignored.

@kaelad02 kaelad02 merged commit ce17f30 into main Apr 6, 2024
1 check passed
@kaelad02 kaelad02 deleted the grantsCriticalRange branch April 6, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant