Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage Enrichers cause an error to be thrown #70

Closed
etiquettestartshere opened this issue May 22, 2024 · 2 comments
Closed

Damage Enrichers cause an error to be thrown #70

etiquettestartshere opened this issue May 22, 2024 · 2 comments

Comments

@etiquettestartshere
Copy link

etiquettestartshere commented May 22, 2024

To reproduce: put a damage enricher like [[/damage formula=1d4 type=fire]] in a journal or chat card and then click it. The TypeError "Cannot read properties of undefined (reading 'actor')" is thrown. Only occurs with Advantage Reminder enabled. Results obtained on Foundry version 11.315 (node.js+chrome), dnd5e 3.1.2, adv-reminder 3.4.1 and 4.0.0, no other modules enabled.

image
image
image
image

@etiquettestartshere
Copy link
Author

I encountered this same issue with Zhell's Effect Macro module, and he determined it is likely to be caused by the first argument of the "dnd5e.preRollDamage" hook, item, being undefined, leading to item.actor causing this error. It seems likely that is the issue here as well.

kaelad02 added a commit that referenced this issue Jun 1, 2024
@kaelad02
Copy link
Owner

kaelad02 commented Jun 1, 2024

made a new release, version 4.0.1, with this bug fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants