Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAE also handles impose stealth disadvantage #15

Closed
kaelad02 opened this issue Jan 25, 2022 · 0 comments · Fixed by #20
Closed

DAE also handles impose stealth disadvantage #15

kaelad02 opened this issue Jan 25, 2022 · 0 comments · Fixed by #20
Labels
enhancement New feature or request

Comments

@kaelad02
Copy link
Owner

DAE added support for armor with stealth disadvantage. The original implantation was for all heavy armor but looks like that's going to be fixed in version 0.8.82 (see issue link below). It does it by adding flags.midi-qol.disadvantage.skill.ste to the actor data.

https://gitlab.com/tposney/dae/-/issues/263

For now this is just a reminder since this module reads the active effects directly rather than any applied versions to the actor data. If, however, that implementation changes we'll have to account for the fact that if DAE of a certain version is loaded, it will add the flag and we don't have to check ourselves.
@kaelad02 kaelad02 added the enhancement New feature or request label Feb 5, 2022
@kaelad02 kaelad02 linked a pull request Feb 5, 2022 that will close this issue
resolve #15 - Let DAE handle impose stealth disadvantage #20
Merged
kaelad02 added a commit that referenced this issue Feb 5, 2022
@kaelad02
resolve #15 - Let DAE handle impose stealth disadvantage (#20)
49cd862 
* add checkArmorStealth option
* create new test to skip check
* create util function for module minimum version
* use isMinVersion to set checkArmorStealth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolve #15 - Let DAE handle impose stealth disadvantage kaelad02/adv-reminder
1 participant
@kaelad02