last-minute cleanup

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 - feature: Support the system's new concentration rolls with sources and messages with `flags.adv-reminder.message.ability.concentration` (system already handles advantage/disadvantage)
 - feature: Support `flags.midi-qol.grants.critical.range` for conditions like Paralyzed that turn hits into crits if the attacker is adjacent. Does not currently work with Ready Set Roll, will just be ignored.
+- feature: Apply conditions directly bases on the `statuses` instead of adding Midi's flags to status effects
 
 # 3.4.1
 

src/reminders.js

@@ -104,9 +104,6 @@ export class AttackReminder extends BaseReminder {
   updateOptions(options) {
     this._message();
 
-    // quick return if there are no flags
-    //if (isEmpty(this.actorFlags) && isEmpty(this.targetFlags)) return;
-
     // build the active effect keys applicable for this roll
     const advKeys = [
       "advantage.all",
@@ -185,9 +182,6 @@ class AbilityBaseReminder extends BaseReminder {
   updateOptions(options) {
     this._message();
 
-    // quick return if there are no flags
-    //if (isEmpty(this.actorFlags)) return;
-
     // get the active effect keys applicable for this roll
     const advKeys = this.advantageKeys;
     const disKeys = this.disadvantageKeys;
@@ -364,9 +358,6 @@ export class CriticalReminder extends BaseReminder {
   updateOptions(options, critProp = "critical") {
     this._message();
 
-    // quick return if there are no flags
-    //if (isEmpty(this.actorFlags) && isEmpty(this.targetFlags)) return;
-
     // build the active effect keys applicable for this roll
     const critKeys = ["critical.all", `critical.${this.actionType}`];
     const normalKeys = ["noCritical.all", `noCritical.${this.actionType}`];